Move /donate_to_fund functionality to /donate route #10

winsonwan · 2024-03-14T03:09:40Z

if account_code_string is empty, then redirect to general fund (/donate?account_code_string=0000)
if account_code_string is in URL but doesn't exist in db, then redirect to general fund and display error message
if account_code_string is in URL and exists in db, then transaction should complete successfully and newly created donation record should be associated with correct account code

…s accessible as param in store_controller#process_donation

…unt code string in path)

…s query parameter instead)

…ocess_donation

…tore_controller#donate

…t code

Reimirno · 2024-03-14T03:15:25Z

It will be better if you:

put in the relevant Tracker story in your PR, so reviewer know what this is for. Or briefly explain what this is for.
Most of the time you always should link a PR to a relevant tracker story/jira ticker.
explain how to test your feature (some reviewers won't test and only look at codes, but at some point someone will)
provide screenshots if it's UI change

winsonwan and others added 12 commits March 5, 2024 10:26

add account_code_string url parameter to quick_donate route

d2a6155

add account_code_string hidden form field to donate view so that it i…

73d0de9

…s accessible as param in store_controller#process_donation

handle account code (valid, invalid -> redirect, blank -> use default)

c83607f

modify existing tests to expect correct redirect url (to include acco…

e2c7aef

…unt code string in path)

remove account_code_string as bounded url parameter (will be passed a…

b843476

…s query parameter instead)

redirect /donate to /donate/:Donation.default_code.code

c1e4056

modify existing tests to expect correct redirect url

a230d54

create tests for initiating recurring donation in store_controller#pr…

43823d2

…ocess_donation

create outline for tests for account_code_string url query param in s…

9580ad3

…tore_controller#donate

modify the view so it displays the name and description of the accoun…

f7cee69

…t code

Quick Donation Tests

7c337d3

delete remnants of recurring donation feature from this branch

15788b6

winsonwan assigned winsonwan and Reimirno and unassigned winsonwan Mar 14, 2024

winsonwan closed this Mar 14, 2024

Provide feedback