[finishes #187093497 #187226906] Added test for missing id in donate_…

…to_fund route. Current theater apps give HTTP ERROR 404 when missing fund code, decided to make id optional and use default fund if missing id

app/controllers/store_controller.rb

@@ -106,6 +106,7 @@ def subscribe
   def donate_to_fund_redirect
     # redirect donate_to_fund route to quickdonate for potential printed material with donate_to_fund url
     fund_code = params[:id]
+    fund_code = Donation.default_code.code if fund_code.blank?
     redirect_to quick_donate_url(account_code_string: fund_code)
   end
 

config/routes.rb

@@ -113,7 +113,7 @@
     get '/store/(:customer_id)' => 'store#index', :defaults => {:customer_id => nil}, :as => 'store'
     get '/subscribe/(:customer_id)' => 'store#subscribe', :defaults => {:customer_id => nil}, :as => 'store_subscribe'
     # get '/donate_to_fund/:id/(:customer_id)' => 'store#donate_to_fund', :defaults => {:customer_id => nil}, :as => 'donate_to_fund'
-    get '/donate_to_fund/:id/(:customer_id)', :defaults => {:customer_id => nil}, to: 'store#donate_to_fund_redirect'
+    get '/donate_to_fund/(:id)/(:customer_id)', :defaults => {:customer_id => nil}, to: 'store#donate_to_fund_redirect'
     get '/store/cancel' => 'store#cancel', :as => 'store_cancel'
 
     # subsequent actions in the above flow require a customer_id in the URL:

spec/controllers/store_controller_spec.rb

@@ -171,6 +171,15 @@
       get :donate_to_fund_redirect, {:id => fund_code, :customer_id => @anon}
       expect(response).to redirect_to(quick_donate_path(account_code_string: fund_code))
     end
+    it 'sets the fund code to default code when it is missing' do
+      get :donate_to_fund_redirect, { :customer_id => @anon }
+      expect(response).to redirect_to(quick_donate_path(account_code_string: Donation.default_code.code))
+    end
+    it 'sets the fund code to default code when it is invalid' do
+      invalid_fund_code = ' '
+      get :donate_to_fund_redirect, { id: invalid_fund_code, :customer_id => @anon }
+      expect(response).to redirect_to(quick_donate_path(account_code_string: Donation.default_code.code))
+    end
   end
 
   describe 'quick donation with nonexistent customer' do