Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187227079/features/pd backend #46

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

JacksonXu33
Copy link

@JacksonXu33 JacksonXu33 commented Mar 30, 2024

[Pivotal Tracker Link][tracker]

What this PR does:

This pull request implements part of the backend for PD model and PD registrations. It did NOT yet add the database migrations, as there is no testing for anything yet.

How should this PR be tested?

Rspec and Cucumber after figuring out how everything connets.

  • Are there edge cases to watch out for?
    Did not account for admin backend control yet, as in PD registrations logistics are not fully setup yet.

Are there any complications to deploying this?

No database migration or testing added yet.

Checklist:

  • Has this been deployed to a staging environment or reviewed by a customer?
  • Tag someone for code review (either a coach / team member)
  • I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 2.24719% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 66.26%. Comparing base (8117d90) to head (08273f2).

Files Patch % Lines
app/controllers/pd_registrations_controller.rb 0.00% 51 Missing ⚠️
...ontrollers/professional_developments_controller.rb 0.00% 28 Missing ⚠️
app/models/pd_registration.rb 0.00% 4 Missing ⚠️
app/models/professional_development.rb 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           pd-frontend+backend      #46      +/-   ##
=======================================================
- Coverage                71.56%   66.26%   -5.31%     
=======================================================
  Files                       24       24              
  Lines                      837      907      +70     
=======================================================
+ Hits                       599      601       +2     
- Misses                     238      306      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perryzjc perryzjc merged commit c9f448a into pd-frontend+backend Apr 2, 2024
10 checks passed
@perryzjc perryzjc deleted the 187227079/features/pd-backend branch April 2, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants