Boxes + horizontal flow makes for more readable call graphs #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my personal set of modifications to the call graph generation. Putting them here to see if anyone else likes them.
Boxes vs ellipses
By having nodes be boxes instead of ellipses, the information packs down so much denser. The "circle" style wastes huge amounts of space on either side. This change is an easy win.
Horizontal flow vs vertical.
This one is more opinionated. When there are more than five or so elements in a given layer, horizontal flow allows much more to be onscreen at once, since the nodes stack short side to short side. Since almost everything I do is looking at full contracts with this tool, this works out much better for me. Vertical ranking means that even on a widescreen monitor, I can't see the whole contract.
Using vertical ranking. (Old, but with boxes)
Using horizontal. (After)