Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync master<> dev #2407

Merged
merged 219 commits into from
Apr 7, 2024
Merged

sync master<> dev #2407

merged 219 commits into from
Apr 7, 2024

Conversation

0xalpharush
Copy link
Contributor

No description provided.

@webthethird
Undo changes from new branch re: cross-contract taint
c1e3743
@webthethird
Add failing test of get_implementation_var
4b07282 
due to get_dependencies missing dependencies
@webthethird
Merge remote-tracking branch 'crytic/slither/dev' into dev-upgradeabi…
11bbe69 
…lity-utils
@webthethird
Add TODO
1e40d19
@webthethird
Create RETURN node for implicit (named) returns
382c5b9
@webthethird
Merge branch 'dev-upgradeability-utils' into dev-named-implicit-returns
c0764c9
@webthethird
Add nodes property getter to YulBlock
ee5a790
@webthethird
Fix implicit returns after parsing Yul blocks
d7ef685
@webthethird
Fix typo
d902457
@webthethird
Black
80ac920
@webthethird
Handle legacy AST too
457b80c
@webthethird
Black
0a16995
@webthethird
Merge branch 'dev' into dev-named-implicit-returns
5e051ce
@webthethird
Do not add implicit return after THROW node
91a63bb
@webthethird
Merge remote-tracking branch 'origin/dev-named-implicit-returns' into…
ba3b604 
… dev-named-implicit-returns
@webthethird
Update expected json artifacts
30794d0
@webthethird
Merge branch 'dev' into dev-named-implicit-returns
53f4842
@webthethird
Update expected json artifacts
643242a
@webthethird
Update compiles
d28bf61
@webthethird
Update json artifacts
f5ef00d
@webthethird
Add missing json artifact
2d8fd3a
@webthethird
Bump
d215d05
@webthethird
Add missing json artifact
d2ae168
@webthethird
Merge remote-tracking branch 'origin/dev-named-implicit-returns' into…
3d8ff74 
… dev-named-implicit-returns
@webthethird
Revert "Update expected json artifacts"
3a0f005 
This reverts commit 643242a.
@webthethird
Revert "Update compiles"
e3a8a98 
This reverts commit d28bf61.
@webthethird
Update 18 affected json artifacts
728e40c
@webthethird
Update expected json artifacts for conditional-all.sol
bffb172
@webthethird
Add parser tests for implicit returns
371ca7d
@webthethird
Fix expected json artifacts
e4864de
dependabot bot and others added 22 commits April 1, 2024 22:07
@dependabot
Bump actions/configure-pages from 4 to 5
3dd3521 
Bumps [actions/configure-pages](https://github.com/actions/configure-pages) from 4 to 5.
- [Release notes](https://github.com/actions/configure-pages/releases)
- [Commits](actions/configure-pages@v4...v5)

---
updated-dependencies:
- dependency-name: actions/configure-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump github/issue-metrics from 2 to 3
c034713 
Bumps [github/issue-metrics](https://github.com/github/issue-metrics) from 2 to 3.
- [Release notes](https://github.com/github/issue-metrics/releases)
- [Commits](github/issue-metrics@v2...v3)

---
updated-dependencies:
- dependency-name: github/issue-metrics
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@0xalpharush
Merge pull request #2397 from crytic/dependabot/github_actions/dev/gi…
2ba9c85 
…thub/issue-metrics-3

Bump github/issue-metrics from 2 to 3
@0xalpharush
Merge pull request #2396 from crytic/dependabot/github_actions/dev/ac…
ef44825 
…tions/configure-pages-5

Bump actions/configure-pages from 4 to 5
@0xalpharush
Merge pull request #2368 from crytic/dev-all-variables
524a863 
Add all variables read/written
@0xalpharush
Merge pull request #2349 from crytic/update-solc-detectors
34f1735 
add known solc bugs, remove allowed versions, improve formatting
@0xalpharush
metamorpho, v4, endaoment work
090c815
@0xalpharush
fix legacy and solc < 0.8.8 aliasing
fc0d9ca
@0xalpharush
fix member of unit alias lookup
e2d0047
@0xalpharush
fix: lookup of type alias as member of contract
9cecef8
@0xalpharush
cleanup code and add test
5a6ef0d
@0xalpharush
Merge pull request #2404 from crytic/fix/contract-member-lookup
8c9b7dd 
fix: lookup of type alias as member of contract
@0xalpharush
add another test and fix pylint issues
0165614
@0xalpharush
remove unused var
dd4ba2d
@0xalpharush
add test for #2307
4cf8c9a
@0xalpharush
Merge pull request #2403 from crytic/fix/scoping
b4f4a20 
resolve available definitions from import by reference ID
@0xalpharush
Merge pull request #2394 from nsiregar/filter-name-reused-only-truffle
7071098 
Filter name-reused detector to only run on Truffle projects (#2390)
@0xalpharush
Merge pull request #2405 from /pull/2331/head
8f018b1 
add test for #2331
@0xalpharush @bart1e
add tests
098851c 
Co-authored-by: bart1e <[email protected]>
@0xalpharush
Merge pull request #2392 from crytic/feat/unused-import
beb3f38 
feat: add detector for unused imports
@0xalpharush
prepare for 0.10.2 release
873319a
@0xalpharush
Merge pull request #2406 from crytic/prepare-release
e2a2ba7 
prepare for 0.10.2 release
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 7, 2024

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

158 files out of 258 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@0xalpharush 0xalpharush merged commit fdf54f6 into master Apr 7, 2024
265 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elopez elopez Awaiting requested review from elopez elopez is a code owner

@montyly montyly Awaiting requested review from montyly montyly is a code owner

@smonicas smonicas Awaiting requested review from smonicas smonicas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@0xalpharush @webthethird @kevinclancy @Tiko7454 @bohendo @dokzai @elopez @smonicas @DarkaMaul @nsiregar