[Bug]: Custom errors with interfaces are not supported

[axic]

Describe the issue:

Custom errors which have contracts/interface types as arguments are not support properly.

Code example to reproduce the issue:

interface K {
}

interface I {
  error SomethingSomething(K k);
}

abstract contract A is I {
}

contract B is A {
  function f() external {
    revert SomethingSomething(K(address(0)));
  }
}

Also note that Solidity accepts:

interface I {
  error SomethingSomething(I i);
}

And that will also result in the same issue in slither.

Version:

0.8.2

Relevant log output:

Missing function Variable not found: SomethingSomething(K) (context B)

[0xalpharush]

Thanks for reporting this. I get the same error on dev, too.

[montyly]

Tested with 0.8.3 - this is still present

[0xalpharush]

This works fine for address types but not for contract types. The AST produced for error SomethingSomething(this) is different than if it was an address type.

slither/slither/solc_parsing/expressions/expression_parsing.py

Lines 447 to 453 in db703d8

	if t:
	found = re.findall("[struct|enum|function|modifier] \(([\[\] ()a-zA-Z0-9\.,_]*)\)", t)
	assert len(found) <= 1
	if found:
	value = value + "(" + found[0] + ")"
	value = filter_name(value)

[montyly]

Hi @axic , we fixed it with #1349, and the fix will be available in the upcoming release (same for #1173)