Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify flake #544

Merged
merged 5 commits into from
Feb 2, 2025
Merged

Simplify flake #544

merged 5 commits into from
Feb 2, 2025

Conversation

bohendo
Copy link
Contributor

@bohendo bohendo commented Jan 17, 2025

Now that crytic.nix is public, we don't need to define nix config for solc-select, crytic-compile, etc in this repo. Instead, we can use the packages provided by crytic.nix.

flake.nix Outdated Show resolved Hide resolved
@bohendo
Copy link
Contributor Author

bohendo commented Jan 28, 2025

Sprinkled a bit of regex into flake.nix to dynamically read the version from cmd/root.go, a couple of implications:

  • This assumes that the version constant defined in cmd/root.go is and remains the source of truth.
  • it hardcodes the regex: .*const version = "([^"]+)".*, this would need to change if eg we rename this variable, switch to single quote raw strings, etc

@anishnaik
Copy link
Collaborator

I've actually decided that i'm a little wary of using the regex for the reasoning you mentioned. I've added it to the release checklist and we can just manually update it every time we cut a release :)

@anishnaik anishnaik merged commit c14c9ae into master Feb 2, 2025
12 checks passed
@anishnaik anishnaik deleted the simple-flake branch February 2, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants