Use `bit` instead of power of two (2 ^ i) #900

elopez · 2023-01-10T15:14:03Z

We are computing powers of two, so using bit performs better.

We are computing powers of two, so using `bit` performs better.

ggrieco-tob · 2023-01-10T15:28:03Z

This is great, but can you keep replacing the usage of 2 ^ i in the same file ? 🙂

2^256 is not representable in a Word256.

elopez · 2023-01-10T18:12:26Z

@ggrieco-tob I did a quick test with most of the 2 ^ x replaced but I did not notice any change in execution times. Also earlier when I profiled a run, I did not see them taking a significant chunk of time. I'm not sure if it is worth changing the other instances.

Maybe if we use fixed size types instead of Integer it would be faster? I'm just guessing at this point 🤔

Use bit instead of power of two (2 ^ i)

361bfd5

We are computing powers of two, so using `bit` performs better.

Consider case with i=256

029b8b8

2^256 is not representable in a Word256.

ggrieco-tob merged commit 428483c into master Jan 13, 2023

ggrieco-tob deleted the dev-constants-opt branch January 13, 2023 10:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `bit` instead of power of two (2 ^ i) #900

Use `bit` instead of power of two (2 ^ i) #900

elopez commented Jan 10, 2023

ggrieco-tob commented Jan 10, 2023

elopez commented Jan 10, 2023

Use bit instead of power of two (2 ^ i) #900

Use bit instead of power of two (2 ^ i) #900

Conversation

elopez commented Jan 10, 2023

ggrieco-tob commented Jan 10, 2023

elopez commented Jan 10, 2023

Use `bit` instead of power of two (2 ^ i) #900

Use `bit` instead of power of two (2 ^ i) #900