Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(opcodes): REVERT EIP #386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sambacha
Copy link

@sambacha sambacha requested a review from bohendo as a code owner January 26, 2025 08:48
Copy link
Member

@elopez elopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! thanks for the PR!

@@ -178,7 +178,7 @@ The gas information is a work in progress. If an asterisk is in the Gas column,
| `0xf6` - `0xf9` | Unused | - | - |
| [`0xfa`](#staticcall) | STATICCALL | Similar to CALL, but does not modify state | - | 40 |
| `0xfb` | Unused | - | - |
| [`0xfd`](#revert) | REVERT | Stop execution and revert state changes, without consuming all provided gas and providing a reason | - | 0 |
| [`0xfd`](#revert) | REVERT | Stop execution and revert state changes, without consuming all provided gas and providing a reason | [EIP 140](https://github.com/axic/EIPs/blob/75121e281a8737f979a969394b4360d4d277c115/EIPS/eip-140.md) | 0 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [`0xfd`](#revert) | REVERT | Stop execution and revert state changes, without consuming all provided gas and providing a reason | [EIP 140](https://github.com/axic/EIPs/blob/75121e281a8737f979a969394b4360d4d277c115/EIPS/eip-140.md) | 0 |
| [`0xfd`](#revert) | REVERT | Stop execution and revert state changes, without consuming all provided gas and providing a reason | [EIP 140](https://eips.ethereum.org/EIPS/eip-140) | 0 |

Can we link to an "official" ethereum URL, to keep consistency with the rest of the table? (I'm providing one as an example, but the table linting will probably be off if you apply it as-is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants