refactor: ameba linting #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 26, 2023 15:40
While there were only 2 methods that flagged this rule, it would require a lot more refactoring of the codebase to resolve it. Maybe one day this can be revisited so that Shards can be optimised even more.
j8r
reviewed
Jan 26, 2023
asterite
reviewed
Jan 26, 2023
HertzDevil
reviewed
Jan 26, 2023
Edit by HertzDevil Co-authored-by: Quinton Miller <[email protected]>
jkthorne
reviewed
Jan 26, 2023
|
No longer interested in pursuing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ameba code analysis/linting tool to Shards to help catch some code structure issues and improve performance.