-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lib to Makefile #344
Add lib to Makefile #344
Conversation
0b914ef
to
913bf4b
Compare
I'm less sure of this now, I think the behaviour should be this:
a good bootstrap for the makefile is: MOLINILLO_VERSION = $(shell $(CRYSTAL) eval 'require "yaml"; puts YAML.parse(File.read("shard.lock"))["shards"]["molinillo"]["version"]')
MOLINILLO_URL = "https://github.com/crystal-lang/crystal-molinillo/archive/v$(MOLINILLO_VERSION).tar.gz" with the target bootstrap:
mkdir -p lib/molinillo
curl -L $(MOLINILLO_URL) | tar -xz -C lib/molinillo --strip-components=1 |
@RX14 I've just enhanced the recipe for |
@@ -17,7 +17,7 @@ commands: | |||
- crystal/shards-install | |||
- run: make | |||
- run: make test | |||
- crystal/format-check | |||
- run: crystal tool format --check src spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this required? It really shouldn't be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See commit message on 4d559ac
tmp/integrations is created by integration specs and contains non-formatted files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe crystal/format-check
(or crystal tool format
) should only apply to spec src
by default. But this is also a very specific problem that shards contains ill-formatted files in its tree after the test have run.
Alternatives would be to run format check before make test
or clean tmp/integrations
afterwards.
I think this is fine |
Is it possible to move forward? Updating the Alpine Linux shards package requires bootstrapping to get |
tmp/integrations is created by integration specs and contains non-formatted files
0f6a069
to
b195b56
Compare
Rebased and squashed. |
Add lib to Makefile
No description provided.