Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal deps --production not updated shards now #141

Closed
kostya opened this issue Nov 24, 2016 · 4 comments
Closed

crystal deps --production not updated shards now #141

kostya opened this issue Nov 24, 2016 · 4 comments

Comments

@kostya
Copy link

kostya commented Nov 24, 2016

i update shard kemal, file shards.lock changed, i commit it, and deploy. (on the server it builded in shared path, i just copy shards.yml, shards.lock to it, from current release and crystal deps --production)

and it works fine, but now code of the shard in the lib, not updated to actual, so it compiled with 0.17.0

diff was

   kemal:
     github: sdogruyol/kemal
-    version: 0.17.0
+    version: 0.17.1

versions in shards.lock now not synced with lib dir, with crystal deps command

@ysbaddaden
Copy link
Contributor

ysbaddaden commented Nov 24, 2016

Do you still have the legacy libs folder on your server? There is a known issue with Crystal 0.20.0's CRYSTAL_PATH where the legacy libs takes precedence over lib. Be sure to delete the libs directory, otherwise Crystal will keep using the old library. See #140.

@kostya
Copy link
Author

kostya commented Nov 24, 2016

no, libs removed, code not updated in lib.

@kostya
Copy link
Author

kostya commented Nov 24, 2016

easy to reproduce:

crystal init app bla
cd bla
printf "\ndependencies:\n  kemal:\n    github: sdogruyol/kemal\n    version: 0.17.0\n" >> shard.yml
crystal deps
cd ..
cp -r bla bla2
cd bla
sed -i -e 's/0.17.0/0.17.1/g' shard.yml
crystal deps update
cd ..
cd bla2
cp ../bla/shard* ./
crystal deps --production
cd ..
diff bla/lib/kemal/src/kemal/context.cr bla2/lib/kemal/src/kemal/context.cr
12,16c12
<       @params ||= if @request.param_parser
<                     @request.param_parser.not_nil!
<                   else
<                     Kemal::ParamParser.new(@request)
<                   end
---
>       @params ||= Kemal::ParamParser.new(@request)

works in previous version

@ysbaddaden
Copy link
Contributor

Duplicate of #107

f-fr pushed a commit to f-fr/shards that referenced this issue Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants