Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for CRYSTAL_DOCKER_IMAGE #137

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Add default value for CRYSTAL_DOCKER_IMAGE #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7d225c
Add default value for CRYSTAL_DOCKER_IMAGE
straight-shoota Sep 22, 2021
26d3254
Use `$(CRYSTAL_VERSION)` as default value
straight-shoota Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CRYSTAL_VERSION ?= ## How the binaries should be branded
CRYSTAL_SHA1 ?= $(CRYSTAL_VERSION) ## Git tag/branch/sha1 to checkout and build source
CRYSTAL_DOCKER_IMAGE ?= ## Which crystal docker build image to use
CRYSTAL_DOCKER_IMAGE ?= crystallang/crystal:$(CRYSTAL_VERSION) ## Which crystal docker build image to use

OUTPUT_DIR = build
OUTPUT_DOCS_BASE_NAME = crystal-$(CRYSTAL_VERSION)-docs
Expand Down