-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround slow compile times for big StaticArray #9486
base: master
Are you sure you want to change the base?
Conversation
ee16b5c
to
0e971dd
Compare
Please, don't merge this yet (#2485 (comment)) |
This should be now superseded by #9510 (if specs passes 🤞 😄 ) |
Closing in favor of #9510, which also reduces the compile time. |
I think it can be fine to have this simple fix for now, before a true codegen fix (eventually by @waj ?) will be ready. |
I'm sorry @j8r but I still don't think it's a good idea. This is basically always unrolling the contents of the block. It might look harmless for small examples but the block could be any piece of code. Whatever the block is, the codegen will be writing LLVM code for it |
Ok, but block are always inlined, so is there really a difference at the end? |
Block calls are inlined but the code from the block is only generated as many times |
Fixes #2485.
I didn't add details on the commit message, having no knowledge of what is causing this slow compile times in the background with LLVM - be free to edit it if somebody wants.