Add missing specs for ->var.foo semantics with assignments
#9419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is one of the reason of our confusion.
jhass
approved these changes
Jun 4, 2020
asterite
requested changes
Jun 4, 2020
crystal-lang#9419 (comment) Co-authored-by: Ary Borenszweig <[email protected]>
|
|
straight-shoota
approved these changes
Nov 21, 2020
caspiano
approved these changes
Nov 3, 2022
|
I don't know why I removed this from the milestone back in the day, when it was already accepted. We can probably just merge it, it's only adding specs =) |
asterite
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is one of the reason of our confusion. Don't you think so, @waj?