Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IO flush to builder finish methods #9321

Merged

Conversation

straight-shoota
Copy link
Member

Resolves #8891
Requires #9320

@straight-shoota straight-shoota changed the title Feature/builder flush finished Add IO flush to builder finish methods May 19, 2020
@straight-shoota straight-shoota force-pushed the feature/builder-flush-finished branch from 30e4e4e to 152159d Compare June 15, 2020 21:46
@straight-shoota straight-shoota marked this pull request as ready for review June 15, 2020 21:51
@straight-shoota straight-shoota force-pushed the feature/builder-flush-finished branch from 152159d to 283778a Compare June 15, 2020 22:01
@bcardiff bcardiff added this to the 1.0.0 milestone Nov 11, 2020
@bcardiff bcardiff merged commit c7c473a into crystal-lang:master Nov 17, 2020
@straight-shoota straight-shoota deleted the feature/builder-flush-finished branch November 17, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align flush behaviour of builders
2 participants