Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfaults when static linking with musl #9238

Merged
merged 1 commit into from
May 7, 2020
Merged

Fix segfaults when static linking with musl #9238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/crystal/system/unix/pthread.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,19 @@ class Thread
@th
end
end

# In musl (alpine) the calls to unwind API segfaults
# when the binary is statically linked. This is because
# some symbols like `pthread_once` are defined as "weak"
# and, for some reason, not linked into the final binary.
# Adding an explicit reference to the symbol ensures it's
# included in the statically linked binary.
{% if flag?(:musl) && flag?(:static) %}
lib LibC
fun pthread_once(Void*, Void*)
end

fun __crystal_static_musl_workaround
LibC.pthread_once(nil, nil)
end
{% end %}