Drop skip_abstract_def_check flag support
#9217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nine months have passed since 0.30.0 was released. It's about time to drop it.
jhass
approved these changes
May 2, 2020
|
Thank you! But what actually needs to be done is turn the warnings into errors. But I think there are still some. bugs with the abstract de checker, so I don't know... |
|
Abstract def checks are solid and the warnings have become errors in #9810. I think we can drop the flag now. It would be a breaking change, though. So we might have to delay that for 2.0. But I don't expect the flag to be used and it was only a dev tool that was never really documented. I think it should be fine to remove. |
straight-shoota
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nine months have passed since 0.30.0 was released. It's about time to drop it.