Refactor is_crystal_repo based on project name #9070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
force-pushed
the
feature/docs-crystal-repo
branch
from
de5c0e7 to
f8b6284
Compare
RX14
approved these changes
Apr 15, 2020
jhass
approved these changes
Apr 15, 2020
|
Needs CI fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how the docs generator knows it's working on stdlib. Previously it looked for a git remote pointing to
github.com/crystal-lang/crystal. Now with #8792 it can simply tell by the project name. That allows generating stdlib docs outside a git environment (for example from a tarball) which was impossible before.For refernce: #7904 might add a separate option for enabling ouput of stdlib features which could make this change obsolete. But that's not fleshed out yet, and this is a simple improvement we can do right now.