Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference global Spec in be_a macro #9066

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Reference global Spec in be_a macro #9066

merged 1 commit into from
Apr 14, 2020

Conversation

asterite
Copy link
Member

Because it was doing Spec::BeAExpectation, if you use be_a inside a module where theree's a Spec type, it will find that instead of the global one.

@asterite asterite added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:specs labels Apr 14, 2020
@RX14 RX14 merged commit 1bf6b10 into master Apr 14, 2020
@RX14 RX14 added this to the 0.35.0 milestone Apr 14, 2020
@straight-shoota straight-shoota deleted the bug/spec-be-a branch April 14, 2020 19:29
@asterite
Copy link
Member Author

@RX14 Thank you!

carlhoerberg pushed a commit to carlhoerberg/crystal that referenced this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants