Pass the command line to cl.exe through a file #9062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because large projects (like the Crystal compiler) surpass the maximal size for the command line when linking the numerous object files. This commit also makes Crystal actually be able to run the linker subprocess, as it removes the unsupported combination of `args` and `shell: true`.
11 tasks
RX14
reviewed
Apr 14, 2020
RX14
approved these changes
Apr 14, 2020
straight-shoota
approved these changes
Apr 14, 2020
RX14
approved these changes
Apr 15, 2020
carlhoerberg
pushed a commit
to carlhoerberg/crystal
that referenced
this pull request
Apr 29, 2020
This is necessary because large projects (like the Crystal compiler) surpass the maximal size for the command line when linking the numerous object files. This commit also makes Crystal actually be able to run the linker subprocess, as it removes the unsupported combination of `args` and `shell: true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because large projects (like the Crystal compiler) surpass the maximal size for the command line when linking the numerous object files.
This PR also makes Crystal actually be able to run the linker subprocess on Windows, as it replaces the unsupported combination of
argsandshell: true.This PR is technically independent from #9043, but clearly some shell-escaping would be very helpful here.