Windows: Remove the workaround using vsnprintf. #8942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not needed, the functions are both defined in legacy_stdio_definitions.cpp in the same way. So use snprintf directly. This partly reverts commit b293b01. But add Link(legacy_stdio_definitions), as that's where these functions reside now, since VS 2015. https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-change-history-2003-2015?view=vs-2019#stdio_and_conio (This one is needed regardless of this change)
|
cc @RX14 |
|
It's an interesting dilemma, as since VS2015 these functions exist only in legacy_stdio_definitions, but before that this file didn't exist. Is it also possible that @RX14's observations originally were done on an older VS than that? |
RX14
approved these changes
Mar 26, 2020
RX14
added
the
platform:windows
carlhoerberg
pushed a commit
to carlhoerberg/crystal
that referenced
this pull request
Apr 29, 2020
This is not needed, the functions are both defined in legacy_stdio_definitions.cpp in the same way. So use snprintf directly. This partly reverts commit b293b01. But add Link(legacy_stdio_definitions), as that's where these functions reside now, since VS 2015. https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-change-history-2003-2015?view=vs-2019#stdio_and_conio (This one is needed regardless of this change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed, the functions are both defined in legacy_stdio_definitions.cpp in the same way. So use snprintf directly.
This partly reverts #5533.
But add
Link(legacy_stdio_definitions), as that's where these functions reside now, since VS 2015.(This one is needed regardless of this change)