-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub issue templates #8934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
I'm not sure if the language improvement discussion should be encouraged to happen here or in the forum (https://forum.crystal-lang.org/c/crystal-contrib). The motivation would be to aim for actionable issues as much as possible.
Another thing that could be done is split the bug & features regarding std-lib or compiler. Splitting that can help to apply initial labels. But I'm not sure it's worth it.
2efca90
to
39b52af
Compare
39b52af
to
1ffb30b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
@bcardiff I might like separation between stdlib and compiler, but it also increases complexity. For a user (especially a novice) it might be difficult to tell where the bug actually originates. So I'd rather leave it combined (at least for now, maybe we get better ideas later).
@j8r I don't see the difference between Language Improvement Discussion and Feature Request. What was your idea for having two separate entries?
@straight-shoota I was finding an issue category more general, which is usually more about an idea than a real feature proposal. |
Co-Authored-By: Sijawusz Pur Rahnama <[email protected]>
Co-Authored-By: Sijawusz Pur Rahnama <[email protected]>
Co-Authored-By: Sijawusz Pur Rahnama <[email protected]>
55abe91
to
cfd21d2
Compare
This is great! I didn't even know this was possible. |
There is also pull request templates. |
I just think that it's not clear what exactly distinguishes I want to start a new discussion about improving the language from I want to propose a new language feature. These descriptions have a fair part of overlap. Also we should probably consider using the expression |
For example, what kind of issue would be "Getting rid of Errno", or any issue related to cleanups/enhancements? That's not really feature proposal. |
Can we move forward this, what are the core members' suggestion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO This is great for last User Experience 👍 Thanks @j8r 🙏
Implements a suggestion posted in the forum.
The main goal is to simplify issue creation, and limit questions unrelated directly to the language being posted in the bug tracker by redirecting users to the correct places to post their questions/issues.
I changed the default branch of my fork to have a preview: https://github.com/j8r/crystal/issues/new/choose.
This is a rough starting-point, core members will certainly have better template ideas that fits more the project.