Enable IO specs on win32 #8822
Merged
Enable IO specs on win32 #8822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:specs
platform:windows
RX14
approved these changes
Feb 20, 2020
bcardiff
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally a part of #8683. I removed IO specs because there was an issue which appeard only after rebasing against master (#8683 (comment)).
The reason is pretty simple though. It's the
#closespecs. They never worked before but were wrapped in an unrelatedpending_win32. 94bf654a reorganized the spec and suddenly#closespecs were running and causing failures in other places.