-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add continuous testing on Windows using GitHub Actions #8676
Conversation
This is a pipeline using a Linux job that cross-compiles for Windows, followed by an actual Windows job linking and running that. Based on https://github.com/crystal-lang/crystal/wiki/Porting-to-Windows/30956f45a4e739204881694ee6c92f4fb0bc5395
This is really amazing! I almost didn't expect to get CI working on windows so quickly. A few remarks:
|
|
It's actually been fixed: |
It's possible to merge this and then update that. |
Actually I'm convinced by your argument that it's much simpler now. |
@oprypin ah, it's fixed on latest You could probably just append that line to the cmakelists to get it to work. But there's still the For now, |
No, didn't work either. |
Well, it can be merged even without #8674, it'll just fail 1 spec initially :> |
@oprypin oh! forgot |
ffs, we'll leave it as is then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small change and we are GTG.
I'm a inclined to allow failures on windows ci, but let's see how it how with the upcoming PRs.
This comment has been minimized.
This comment has been minimized.
Ah no nevermind, it's just the old state of the repository because I'm not rebasing my branch. Good to go. But I have dropped the commit that allows Actions to also run on pull requests, to be on the safe side for now. |
I'd actually prefer running it on pull requests to immediately see whether the changes would break on windows. It's acceptable if builds occasionally break. That's the same with |
Co-Authored-By: Brian J. Cardiff <[email protected]>
Let's see how it goes :-) Maybe if the free tier is not enough we might need to limit branch names. Thanks @oprypin and others :-) |
We could do the same for Alpine aarch64 🙏 |
|
@oprypin Didn't you say the actions wouldn't be triggered on pull requests? Am I missing something here: https://github.com/crystal-lang/crystal/pull/8683/checks?check_run_id=415666174 |
Oh sorry, I re-added that, per request |
This is a pipeline using a Linux job that cross-compiles for Windows, followed by an actual Windows job linking and running that.
Based on https://github.com/crystal-lang/crystal/wiki/Porting-to-Windows/30956f45a4e739204881694ee6c92f4fb0bc5395
Note that all the actual commits from this PR are prefixed with "Win CI:", the rest is merges of pull requests that this relies on.
This PR creates and touches only the file ".github/workflows/win.yml".
Example in action
Fixes #8666.