Fix specs on win32 #8670
Merged
Fix specs on win32 #8670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
RX14
reviewed
Jan 10, 2020
| @@ -106,7 +106,7 @@ describe "#print Float64" do | |||
| test_pair 5.5626846462680035e-309, "5.562684646268003e-309" | |||
| end | |||
|
|
|||
| it "falure case" do | |||
| pending_win32 "failure case" do | |||
There was a problem hiding this comment.
I have no idea. It returns a different result. Maybe that's expected? IDK. Needs investigation into the win32 libs.
There was a problem hiding this comment.
It seems there is something fundamentally broken with floating point numbers on win32:
"%f" % 1.0 # => "0.000000"
oprypin
reviewed
Jan 11, 2020
oprypin
added a commit
to oprypin/crystal
that referenced
this pull request
Jan 11, 2020
RX14
reviewed
Jan 11, 2020
RX14
approved these changes
Jan 11, 2020
oprypin
reviewed
Jan 11, 2020
Sija
reviewed
Jan 11, 2020
straight-shoota
force-pushed
the
fix/win32-specs
branch
from
ba70814 to
f5498ff
Compare
We need to sort the expected results in order to make the specs pass on Windows because `foo\` and `foo/` compare differently with `foo2`.
straight-shoota
force-pushed
the
fix/win32-specs
branch
from
f5498ff to
1b6514e
Compare
|
Rebased to squash fixups. |
RX14
reviewed
Jan 13, 2020
straight-shoota
force-pushed
the
fix/win32-specs
branch
from
1b6514e to
3f0feea
Compare
RX14
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This either fixes or disables specs that don't succeed on win32.
With this and #8668
win32_std_spec.crshould be all green 👍