Compiler: fix type flow of var in if with && #7785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
bcardiff
approved these changes
May 15, 2019
bew
reviewed
May 16, 2019
| end | ||
|
|
||
| foo | ||
| ), inject_primitives: false) { int32 } |
There was a problem hiding this comment.
I don't understand your test, in all cases the return type can only be int32, I think you want to return false or some other type?
There was a problem hiding this comment.
That's the point: This test ensures that the compiler recognizes that the return type is always Int32, because the if branch can never be reached.
There was a problem hiding this comment.
oooh ok I think I get it, it'd be far easier to understand if we could do:
if true && (y = 1 || nil)
end
assert_type(y, Int32)Or maybe just do:
assert_type(%(
if true && (y = 1 || nil)
end
y
), inject_primitives: false) { int32 }?
There was a problem hiding this comment.
But in your examples y ends up nilable. It's the return in the else branch that makes it non nilable. But that what was not working well (when in a right side of &&).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7434
This one is harder to explain so I'm going to skip that.