Compiler: fix require relative path resolution #7758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
asterite
force-pushed
the
bug/crystal-path-relative
branch
from
f02897c to
b12e734
Compare
|
Cool, I thought I implemented something wrong but it turned out we had a couple of invalid |
Fryguy
reviewed
May 10, 2019
| end | ||
| else | ||
| relative_filename = "#{relative_to}/#{filename}" | ||
| return unless relative_to.is_a?(String) |
There was a problem hiding this comment.
I know this was in the original code, but why not have relative_to be typed to a String right in the signature?
There was a problem hiding this comment.
Good point. I will do this, I think it will simplify code (I thought it was being passed other things than String or Nil but it doesn't seem to be the case). Thanks!
There was a problem hiding this comment.
Actually, never mind. This can be done in a separate PR. If somebody wants to do it, please go ahead.
ysbaddaden
approved these changes
May 10, 2019
asterite
force-pushed
the
bug/crystal-path-relative
branch
from
cce8a54 to
2f53e5b
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7408