Detect deprecation on initialize methods and methods with named args #7724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
added
kind:bug
straight-shoota
approved these changes
Apr 28, 2019
bcardiff
force-pushed
the
fix/deprecated-named-args
branch
from
e0fd5fd to
7730e99
Compare
asterite
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations were not kept from the original method to the expanded overload for named args.
For generated
.newmethods the annotations of the matching#initializeshould be kept.The call from new to initialize should not generate a warning since it's an implementation detail. For this case, an explicit check following the convention used by the compiler is used.
Fixes #7714