Upgrade CI to use Crystal 0.28.0 #7705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same should be done in linux once LIBRARY_PATH is not defined in docker images. Or it could be set in the Makefile when building the compiler_specs directly probably.
waj
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also removes the dependency with homebrew crystal formula. Once the tagged release is built we can upgrade our CI directly.
The compiled compiler will use the same CRYSTAL_LIBRARY_PATH as the installed compiler. Hence, there is no need to manually install bdw-gc. This was already done in linux distros since the docker images define a LIBRARY_PATH pointing to the embedded crystal libs. On next release that can be changed to use CRYSTAL_LIBRARY_PATH directly.
Upgrades master to 0.29.0-dev.
Preview of build at https://circleci.com/workflow-run/c9ecbdc4-ae0e-4f19-8034-f5254cf78344