Fix offsetof not being usable with macros #7703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some specs would nice :) |
asterite
reviewed
Apr 21, 2019
|
I say it because visitor should be respected. This is probably some issue in ToSVisitor, check that you implement that and that you return false in the method so children aren't revisited/printed. |
|
I can confirm that's the issue. Just add a new line at the end of the method overload for OffsetOf in ToSVisitor that says false (but please keep the test). |
|
Or even better, remove this test and add a test to the to s visitor. |
malte-v
force-pushed
the
bug/7702-macros-with-offsetof
branch
from
9fbb4ab to
ec8e276
Compare
|
I just realized my "solution" breaks much more that it fixes, e.g. type aliases stopped working with |
asterite
approved these changes
Apr 22, 2019
bcardiff
added
kind:bug
bcardiff
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7702.