-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Int div deprecation #7639
Int div deprecation #7639
Conversation
10ce45c
to
1c2b853
Compare
Ready for the review! |
1c2b853
to
30bda77
Compare
What about a more imperative style:
Instead of:
|
In 0.29.0: Number#/ will mean arithmetic division Number#// will mean integer (and floor) division
30bda77
to
32d7654
Compare
Both suggestions addressed. |
I have a problem: |
@j8r it's disabled by default. When there is a change of the semantic although it's not a formal deprecation you need to call for a review at least. What it is lacking is a way to mark the warning as solved for example in the code. Although I am fine with dealing some false-positive reports. A fully smooth migration would be to force every |
Yes I know warnings are disabled by default @bcardiff. Still, this is misleading to mark |
But that's exactly why its current use needs to be deprecated. You could just see it like this: |
The signature change, right. I doubt this really matter anyway. This isn't like this warnings will impact non insiders, unless they are curious about tryings flags or read the changelog. That's fine then. |
Depends on #7638.
This PR replaces (hopefully) all usages of
Int#/
withInt#//
.Int#/
is marked as deprecated. This will cause some noise while building the compiler and specs since the method is still tested and used in places like macro interpreter. Without turning off warnings on some lexical scope we will need to tolerate that noise for a bit.Since the stdlib is not ignored bye defualt (only
./lib
) if there are some functions without coverage in the stdlib users will notice them and will be able to report :-)Ref: #2968
Submitting as draft until #7638 is merged