Pending leftovers to support // and &-ops in multiple places #7628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
approved these changes
Apr 4, 2019
straight-shoota
approved these changes
Apr 4, 2019
sdogruyol
approved these changes
Apr 5, 2019
ysbaddaden
approved these changes
Apr 5, 2019
jhass
approved these changes
Apr 5, 2019
bcardiff
force-pushed
the
feature/macro-int-div
branch
from
0c54cb8 to
e540560
Compare
|
Thanks for all the reviews, but the CI wasn't happy. |
bcardiff
changed the title
bcardiff
commented
Apr 5, 2019
| @@ -83,11 +83,20 @@ describe "Semantic: static array" do | |||
|
|
|||
| it "types static array new with size being a computed constant" do | |||
| assert_type(%( | |||
| struct Int | |||
| def //(other : Int) | |||
There was a problem hiding this comment.
I've found it a bit odd that the value of SIZE can be computed by the math interpreter but the definition is still needed. It's similar to what is done in https://github.com/crystal-lang/crystal/blob/master/spec/compiler/semantic/const_spec.cr#L237-L239 .
There was a problem hiding this comment.
It's just needed for the typing phase, so the implementation can be just a 0. I've just pushed that change
The parser already handle ://, :&+ etc as valid symbols
Remove unneeded quoted symbols from highlighter
bcardiff
force-pushed
the
feature/macro-int-div
branch
from
71be379 to
5397e39
Compare
straight-shoota
approved these changes
Apr 9, 2019
asterite
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some missing bits to fully support
//in all places were/is supported today.Ref: #2968