Compiler: Avoid showing duplicate entries as warnings #7626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
added
kind:bug
asterite
approved these changes
Apr 4, 2019
sdogruyol
approved these changes
Apr 4, 2019
bew
reviewed
Apr 4, 2019
bcardiff
force-pushed
the
fix/ignore-duplicate-warnings
branch
from
ee2b0e9 to
8a60d93
Compare
|
@asterite @sdogruyol the first push was not right. I added a couple of more tests to ensure that a warning is reported once per receiver's type of the call plus the invocation location. |
straight-shoota
approved these changes
Apr 4, 2019
sdogruyol
approved these changes
Apr 5, 2019
bcardiff
added a commit
to bcardiff/crystal
that referenced
this pull request
Apr 8, 2019
…l-lang#7626)" This reverts commit 23a7cca.
bcardiff
added a commit
to bcardiff/crystal
that referenced
this pull request
Apr 8, 2019
…l-lang#7626)" This reverts commit 23a7cca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A leftover from #7596. Warnings should appear once per deprecated methods and not once per invocation.