Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace PNG icon with optimized SVG for playground #7616

Merged
merged 7 commits into from
Jan 21, 2022
Merged

Replace PNG icon with optimized SVG for playground #7616

merged 7 commits into from
Jan 21, 2022

Conversation

straight-shoota
Copy link
Member

Closes #6768

ImgBotApp and others added 5 commits April 3, 2019 10:04
@ImgBotApp @straight-shoota
[ImgBot] optimizes images
1d1ede6 
/src/compiler/crystal/tools/playground/public/icon.png -- 2.89kb -> 1.86kb (35.49%)
@IDouble @straight-shoota
➕ Add Icon SVG
459fbda
@IDouble @straight-shoota
➖ Remove Icon png
897f36c
@IDouble @straight-shoota
➕ Use icon.svg
ed45e72
@straight-shoota
Optimize SVG
850f0c3
bcardiff
bcardiff previously requested changes Apr 4, 2019
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 The <img> ends with size 0x0 (tested in Chrome and Firefox)

@jkthorne
Copy link
Contributor

jkthorne commented Apr 8, 2019

Does this change the Browsers that can run this?
I would imagine we are targeting Firefox, Chrome, Safari and Opera right?

@straight-shoota
Copy link
Member Author

SVG support has been in all relevant browsers for 10 years or so.

@jkthorne
Copy link
Contributor

jkthorne commented Apr 8, 2019

I thought so but I was not sure and thought I would ask.

@straight-shoota straight-shoota added this to the 1.4.0 milestone Dec 30, 2021
@straight-shoota straight-shoota merged commit 5d5f95d into crystal-lang:master Jan 21, 2022
@straight-shoota straight-shoota deleted the refactor/reduce-image-size branch January 21, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin oprypin approved these changes

@bcardiff bcardiff bcardiff left review comments

Assignees
No one assigned
Labels
kind:refactor topic:tools:playground
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@straight-shoota @jkthorne @oprypin @bcardiff @ImgBotApp @IDouble