Disable double write buffering in OpenSSL sockets #7460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
approved these changes
Feb 20, 2019
|
I approve this because:
@carlhoerberg Thank you! |
ysbaddaden
approved these changes
Feb 20, 2019
|
I wonder if tests can be included for this. That way this stays working forever. |
|
At least by including some manual specs (which are run before releasing, I think). This is in |
|
I don't know if it's reliable for all kind of things related to OpenSSL buffering, but for this case this code triggered it every time: #7456 (comment) |
urde-graven
pushed a commit
to urde-graven/crystal
that referenced
this pull request
Feb 25, 2019
urde-graven
pushed a commit
to urde-graven/crystal
that referenced
this pull request
Feb 27, 2019
* fixes: Foreign exceptions: basic support Added support for `.so' libraries, fixed segfault, small bugs OptionParser: optional options and arguments shifting XML: workaround for bug in libxml2 2.9.9 (crystal-lang#7477) Implement resource owner credentials (crystal-lang#7424) Implement #annotations (crystal-lang#7326) Handle signals in a separate fiber Compiler: reactively compute a union's type, and check for missing types Compiler: fix as? casting when target doesn't have a type yet Compiler: fix as casting when target doesn't have a type yet Compiler: give pare error when assigning a constant inside a multiassign Format: fix indent of nested array elements (crystal-lang#7450) Disable double write buffering in OpenSSL sockets (crystal-lang#7460)
bcardiff
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7458 and #7456