Fix formatting of 1\n.as(Int32)
#7347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
wooster0
reviewed
Jan 30, 2019
|
I added a couple of commits because I fixed some things but broke others. Now everything should work fine. Later we can squash merge all commits. |
RX14
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6006
This PR consists of two commits:
Calls for special calls likeis_a?,asandresponds_to?and format these calls. This removes a lot of code that was special-cased for this. In this way the logic of formatting calls (which isn't that trivial because it tries to align columns, for example) is kept unified for all these calls.1\n.as(Int32)#6006 but I added a couple of specs to prove it