Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different values than only -1, 0 and 1 to be returned by <=> #7277

Merged
merged 7 commits into from
Mar 6, 2019

Conversation

wooster0
Copy link
Contributor

@wooster0 wooster0 commented Jan 5, 2019

Closes #7276

This changes the spaceship's documentation to allow more values than only -1, 0 and 1 to be returned.

src/array.cr Outdated Show resolved Hide resolved
src/char.cr Show resolved Hide resolved
#
# See also: `Object#<=>`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because Object#<=> no longer exists.

spec/std/array_spec.cr Show resolved Hide resolved
src/char.cr Outdated Show resolved Hide resolved
src/number.cr Outdated Show resolved Hide resolved
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to use the scheme returns -1, 0, 1 (or neg, zero, pos) depending on ... everywhere in the documentation. If you want to change that...

But I'll approve either way.

src/comparable.cr Outdated Show resolved Hide resolved
src/comparable.cr Outdated Show resolved Hide resolved
src/partial_comparable.cr Outdated Show resolved Hide resolved
src/partial_comparable.cr Show resolved Hide resolved
@straight-shoota straight-shoota added this to the 0.28.0 milestone Feb 11, 2019
@straight-shoota straight-shoota merged commit a43fb94 into crystal-lang:master Mar 6, 2019
@straight-shoota
Copy link
Member

Thank you @r00ster91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants