Fix Time::Span initializer from big seconds and sleep with big seconds #7221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
force-pushed
the
bug/time-span-seconds-too-big
branch
from
3294a23 to
ca3452b
Compare
straight-shoota
approved these changes
Dec 27, 2018
ysbaddaden
approved these changes
Dec 27, 2018
bcardiff
approved these changes
Dec 27, 2018
bcardiff
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7220
The two commits are self-descriptive. In the first case it was silently overflowing because the
to_i64was applied too late. In the second case an incorrectto_icall was used when casting toTimeTshould have been used.I think in both cases this would have been caught by an overflow error in the overflow branch (but I didn't try it).
(I don't think there's a way to test
sleep, so no tests for that)