Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow underscores when initlalising BigInt #7108

Closed
wants to merge 1 commit into from
Closed

Allow underscores when initlalising BigInt #7108

wants to merge 1 commit into from

Conversation

alex-kampa
Copy link

Implements #7106

@Sija
Copy link
Contributor

Sija commented Nov 23, 2018

Duplicate of #7107

@bcardiff
Copy link
Member

It’s duplicate but this pr adds some docs :-)

Luckily we don’t need to discuss the implementation.

Thank you both for the contribution.

@bcardiff
Copy link
Member

Closing since #7107 ended up implementing the same feature for other Big numbers (decimal, floats).

@bcardiff bcardiff closed this Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alex-kampa @Sija @bcardiff @asterite