Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing SIGSEGV spec #6995

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Conversation

damaxwell
Copy link
Contributor

On linux the spec "seg fault reports SIGSEGV" is intermittently failing because the process is exiting with success. I.e, it looks like the desired seg fault is not being generated. I have not reproduced this, but presumably the hard-coded pointer address in the spec is intermittently in user space.

Fixed by dereferencing a null pointer instead, which should always generate a seg fault.

@straight-shoota
Copy link
Member

I've noticed that failing spec as well. Thanks for investigating!

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @damaxwell 👍

Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@RX14
Copy link
Contributor

RX14 commented Oct 26, 2018

Probably lack of ASLR (boo)

@RX14 RX14 added this to the 0.27.0 milestone Oct 26, 2018
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib topic:stdlib:specs labels Oct 26, 2018
@RX14 RX14 merged commit fed95f7 into crystal-lang:master Oct 26, 2018
@damaxwell damaxwell deleted the null-deref-spec branch October 31, 2018 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:specs topic:stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants