Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HTTP client spec to remove inheritance for test server #6909

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Refactor HTTP client spec to remove inheritance for test server #6909

merged 1 commit into from
Oct 6, 2018

Conversation

straight-shoota
Copy link
Member

The mock server implementation doesn't need a custom subtype of TCPServer.

sdogruyol
sdogruyol approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @straight-shoota 👍

@sdogruyol sdogruyol merged commit dce1caa into crystal-lang:master Oct 6, 2018
@sdogruyol sdogruyol added this to the 0.27.0 milestone Oct 6, 2018
@straight-shoota straight-shoota deleted the jm/refactor/http-client-spec-tcp-refactor branch October 6, 2018 08:39
@straight-shoota straight-shoota mentioned this pull request Oct 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib:specs topic:stdlib
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@straight-shoota @sdogruyol @RX14