Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSV.build about the corner case of quoting Chars and Symbols #6904

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Fix CSV.build about the corner case of quoting Chars and Symbols #6904

merged 1 commit into from
Oct 3, 2018

Conversation

maiha
Copy link
Contributor

@maiha maiha commented Oct 3, 2018

CSV.build now handles the corner case of quoting Chars and Symbols those contain quotes inside.

CSV.build do |csv|
  csv.row ','
  csv.row '"'
  csv.row :ab
  csv.row :"a,b"
  csv.row :"a\"b"
end
","
""""
ab
"a,b"
"a""b"

Best regards,

@RX14 RX14 added this to the 0.27.0 milestone Oct 3, 2018
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib labels Oct 3, 2018
bcardiff
bcardiff approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maiha

@RX14 RX14 merged commit 25de751 into crystal-lang:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@maiha @bcardiff @RX14