-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pending
to be used without blocks
#6732
Allow pending
to be used without blocks
#6732
Conversation
Both `it` and `pending` can be used in RSpec without a block. Calling `it` without a block is a way of specifying that it is pending. I was caught off guard when writing a spec and it failed in both instances because I lacked a block.
|
Is the |
it is an alias |
I'm pulling these at the request of @asterite. Doesn't really make sense to have them here as there's no way other than manual verification to ensure that they have the intended behavior.
@straight-shoota, @RX14 the documented way to mark tests as incomplete in RSpec is to write |
Yes, but this is not RSpec and Crystal tries to avoid aliases. I guess anyone will be surprised to find out there's no let, before each, etc. |
In fairness, @asterite – when I came across no I'll remove the new |
Summerizing here: Crystal's Spec isn't RSpec. There's enough slight changes that having to write `pending` without a block won't be a huge deal.
it
and pending
to be used without blockspending
to be used without blocks
Both
it
andpending
can be used in RSpec without a block. Callingit
without a block is a way of specifying that it is pending. I was caught off guard when writing a spec and it failed in both instances because I lacked a block.