Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize methods between JSON::Any/YAML::Any #6556

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Standardize methods between JSON::Any/YAML::Any #6556

merged 1 commit into from
Jan 2, 2019

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Aug 17, 2018

Details:

  • Adds #as_bool? and #as_bool to YAML::Any
  • Separate Int32/Int64 and Float32/Float64 tests in the JSON::Any specs
  • Standardize and shorten conditions for nillable variants of cast methods

@j8r
Copy link
Contributor Author

j8r commented Aug 25, 2018

I'm wondering, why not having as_b instead of as_bool ?

@j8r j8r force-pushed the yaml-json-any-standardization branch from 8dad6f4 to 3bf3adb Compare December 8, 2018 19:31
@asterite asterite added this to the 0.27.1 milestone Jan 2, 2019
@asterite asterite merged commit 221f3aa into crystal-lang:master Jan 2, 2019
@j8r j8r deleted the yaml-json-any-standardization branch January 25, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfaust vladfaust vladfaust left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

@asterite asterite asterite approved these changes

@ysbaddaden ysbaddaden ysbaddaden approved these changes

Assignees
No one assigned
Labels
kind:feature kind:refactor topic:stdlib:serialization
Projects
None yet
Milestone
0.27.1
Development

Successfully merging this pull request may close these issues.
5 participants
@j8r @ysbaddaden @asterite @straight-shoota @vladfaust