Allow creating None enum flag with Enum.from_value #6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bew
force-pushed
the
allow-creating-none-enum-flags-from-value
branch
from
c62e23a to
5736077
Compare
|
Good to go? (one of travis check failed for another reason) |
RX14
approved these changes
Dec 27, 2018
|
Can this be rebased on master so we're sure there are no more spec failures? |
bew
force-pushed
the
allow-creating-none-enum-flags-from-value
branch
from
5736077 to
b7fca2b
Compare
bew
commented
Dec 27, 2018
|
So I rebased on master, one of travis job fails for a weird reason: https://travis-ci.org/crystal-lang/crystal/jobs/472825523 |
|
@bew thats just OOM |
yeah sure, but it's still not wanted^^ |
|
Travis builds randomly fail from OOM all the time |
straight-shoota
approved these changes
Dec 31, 2018
asterite
approved these changes
Jan 2, 2019
|
@bew Could you rebase on master to make sure it's still valid? |
bew
force-pushed
the
allow-creating-none-enum-flags-from-value
branch
from
b7fca2b to
8b7f7b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5768
It also adds type restrictions to
Int, and fix one usage insrc/debug/elf.cr