Add closed state to HTTP::Server::Response #6477
Conversation
straight-shoota
force-pushed
the
jm/fix/http-response-close
branch
from
998a533 to
82dc655
Compare
| def closed? | ||
| @closed | ||
| end | ||
|
|
There was a problem hiding this comment.
I guess this should be checked in unbuffered_write?
There was a problem hiding this comment.
IO::Buffered#write already calls check_open. This is ensured with the expect_raises expectation.
| @@ -154,6 +159,7 @@ class HTTP::Server | |||
| @sync = false | |||
| @flush_on_newline = false | |||
| @chunked = false | |||
| @closed = false | |||
There was a problem hiding this comment.
@asterite This is in #reset. I'm not sure how useful this is, because when a request is closed, at least the headers has already been written to the underlying IO. This effectively can't be reset because the response is already sent.
There was a problem hiding this comment.
Oh, cool. Reset is useful, can't remember now why, but response is reused for keep alive, check request processor.
There was a problem hiding this comment.
Oh yeah, RequestProcessor resets the response to avoid allocating a new instance for each iteration.
There was a problem hiding this comment.
I'll add a comment about this.
sdogruyol
added
kind:bug
Fixes #6465