rename alias HTTP::Handler::Proc to HTTP::Handler::HandlerProc #6453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… std Proc type isn't overridden
|
I'm not sure what that travis error is. |
|
@jwoertink Unrelated to this PR, see #5890 |
|
Ok cool. Just making sure I didn't break something lol |
bcardiff
approved these changes
Aug 6, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6386
I know that the name is a bit verbose, but naming is hard. 😂 If anyone has a suggestion for a better name, I'll make the change.
The reason for the rename as mentioned in that issue is that when you are creating a custom HTTP::Handler, and you include it in your class, you're not able to use the standard type
Procanymore since it's been overridden by the alias. I hope no one was using this in particular, but it should probably be noted as a breaking change just in case.