Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: missing virtual types in literal type guessing #6341

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Fix: missing virtual types in literal type guessing #6341

merged 1 commit into from
Jul 6, 2018

Conversation

asterite
Copy link
Member

@asterite asterite commented Jul 6, 2018

Fixes #5342

A few virtual_type calls were missing.

bcardiff
bcardiff approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the long run something to have in mind is to default to virtual type and anchor when a type value should not be virtualized.

@asterite
Copy link
Member Author

asterite commented Jul 6, 2018

Yeah, right now virtual types make the language really complex, so having that by defaut might be a good idea.

@ysbaddaden ysbaddaden merged commit 8acbd26 into crystal-lang:master Jul 6, 2018
@ysbaddaden ysbaddaden added this to the Next milestone Jul 6, 2018
@asterite asterite deleted the bug/5342-guess-literals-virtual branch July 6, 2018 22:54
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler labels Jul 7, 2018
@RX14 RX14 modified the milestones: Next, 0.26.0 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.
4 participants
@asterite @bcardiff @ysbaddaden @RX14