Add TAP formatter to spec suite #6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
force-pushed
the
jm/feature/spec-tap
branch
from
3719fea to
40f0e40
Compare
wooster0
reviewed
Jun 28, 2018
|
|
||
| def report(result) | ||
| case result.kind | ||
| when :success |
There was a problem hiding this comment.
This should be when :success, :pending. And the when :pending should be removed.
There was a problem hiding this comment.
Nope, that would reduce visibility. Separate entries makes it obvious what we're looking at.
RX14
approved these changes
Jun 29, 2018
|
Might want to think about printing the version line, but it's not required for this version of the spec. |
|
@RX14 I had the idea to attach some diagnostics (location, failure message) to the test reports similar to this: https://github.com/MakeNowJust/tap/blob/master/spec/fizzbuzz.txt |
straight-shoota
force-pushed
the
jm/feature/spec-tap
branch
from
c43793b to
0659bab
Compare
|
Rebased to squash changes in logical commits and trigger CI-rebuild. |
jhass
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a formatter for test anything protocol (TAP) to
Spec.The first two commits refactor some aspects of spec formatter implementation, the third finally implements
TAPFormatter.STDOUTti make it easier to test them.DotFormatterandVerboseFormatter